search

netgen / TagsBundle

Netgen Tags Bundle is an eZ Platform bundle for taxonomy management and easier classification of content, providing more functionality for tagging content than ezkeyword field type included in eZ Platform kernel.
https://netgen.io
GNU General Public License v2.0
48 stars 43 forks source link

New Criterion "TagSubtree" matching the "path_string" of tags #160

Open pkamps opened 10 months ago

pkamps commented 10 months ago

Hi,

for a client project we need to be able to filter by a tag subtree. For example, there is a parent tag called "Category" and there are multiple children tags like "USA", "World" etc. The content objects only have the tags "USA" or "World" assigned (not the "Category" tag). We want to be able to find/filter all content that has any children tags of the "Category" tag.

Therefore I developed a new custom Criterion matching values against the DB field "eztags.path_string". Is that something you consider to add to the official repo?

emodric commented 9 months ago

@pkamps This needs running cs fixer to fix some coding standards issues as well as a phpstan error.

I suppose you did not need Solr visitor, hence no implementation?

pkamps commented 9 months ago

I fixed 1 PHPStan error I introduced. There are 3 remaining but not related to this pull request. I believe I fixed the CS issues but the checker still fails - maybe it's not configured correctly?

So far, I don't need the Solr visitor - should I implement it to make this pull request more complete?

emodric commented 9 months ago

I fixed 1 PHPStan error I introduced. There are 3 remaining but not related to this pull request. I believe I fixed the CS issues but the checker still fails - maybe it's not configured correctly?

Thanks for the fixes! I have no idea about CS Fixer, it worked on last push to master and I will try to fix lingering PHPStan issues once I merge this.

So far, I don't need the Solr visitor - should I implement it to make this pull request more complete?

If it's not too much trouble :)