netgen / TagsBundle

Netgen Tags Bundle is an eZ Platform bundle for taxonomy management and easier classification of content, providing more functionality for tagging content than ezkeyword field type included in eZ Platform kernel.
https://netgen.io
GNU General Public License v2.0
48 stars 44 forks source link

Follow ez platform 7.2 db upgrade example #73

Closed wizhippo closed 6 years ago

wizhippo commented 6 years ago

Not sure if we should document this but some users while upgrading to ez platform 7.2 when it comes out may get some errors while converting to utf8mb4 as the ez platform upgrade script does not update the indexes for eztags.

Perhaps tags bundle should provide an upgrade script too along the lines of https://github.com/ezsystems/ezpublish-kernel/blob/master/data/update/mysql/dbupdate-7.1.0-to-7.2.0.sql?

emodric commented 6 years ago

That's a good idea, yes. But, what indexes qualify to have their length shortened to 191? Those that can have data larger than 191? In that case, only two indexes qualify: idx_eztags_keyword and idx_eztags_keyword_id. What do you think?

wizhippo commented 6 years ago

Looks like the local on the primary key of eztags_keyword needs to be addressed too.

ALTER TABLE `eztags` DROP KEY `idx_eztags_keyword`;
ALTER TABLE `eztags` ADD KEY `idx_eztags_keyword` (`keyword` (191));

ALTER TABLE `eztags` DROP KEY `idx_eztags_keyword_id`;
ALTER TABLE `eztags` ADD KEY `idx_eztags_keyword_id` (`keyword` (191), id);

ALTER TABLE `eztags_keyword` DROP PRIMARY KEY;
ALTER TABLE `eztags_keyword` ADD PRIMARY KEY (`keyword_id`, `locale`  (191));
emodric commented 6 years ago

@andrerom @alongosz Do you think this might be part of eZ Platform upgrade instructions, given TagsBundle is included in eZ Platform installs?

andrerom commented 6 years ago

It could be part of upgrade docs, yes. but as it is only included in demo it should distinguish what part is relevant for TagsBundle. /cc @SylvainGuittard

emodric commented 6 years ago

@SylvainGuittard @andrerom Any news here?

Truth to be told, I have no clear picture where to document this. In install instructions or upgrade instructions? For which version?

andrerom commented 6 years ago

Unsure, but until fully bundled with clean install making this a PM issue, maybe document it here for now.

emodric commented 6 years ago

Fixed in fd7bd3ea5acdadc4eaa94ef7a478d56860e1c2b8