search

netgen / ezplatform-search-extra

Netgen's extra bits for eZ Platform search
https://netgen.io
GNU General Public License v2.0
13 stars 4 forks source link

NGSTACK-489 Extra solr fields #52

Closed RandyCupic closed 3 years ago

RandyCupic commented 3 years ago

Currently it's not possible to fetch additional Solr fields during content search (eg. if we indexed some additional data with the document field mapper). With this PR, we can use our overridden query and provide the list of extra fields that we want to extract from Solr documents. Those fields, if exist, will appear in our overridden SearchHit.

pspanja commented 3 years ago

Fantastic 😄

Do you have time to add some tests? From my POV it would be OK to use existing fields as extra fields.

pspanja commented 3 years ago

I just realized, we need to migrate CI from Travis to GitHub Actions to get the tests running again. If you are up for it, it was already migrated on Site API repo, otherwise I can take care of it, will probably have time tomorrow morning.

RandyCupic commented 3 years ago

@pspanja Will do :)

RandyCupic commented 3 years ago

@pspanja I've adjusted existing tests, wrote a new test for extra fields functionality and wrote some documentation for it.

pspanja commented 3 years ago

Sorry for the delay on this, it was a bit busy period.. it looks great overall, I found just one minor bug and a language nitpick.

RandyCupic commented 3 years ago

Sorry for the delay on this, it was a bit busy period.. it looks great overall, I found just one minor bug and a language nitpick.

No problem :) I've fixed the bug and the language nitpick.

pspanja commented 3 years ago

Thanks @RandyCupic 👍