search

netgen / ezpublish-kernel

eZ Publish API and kernel. This is the heart of eZ Publish 5. This is a v2014.11 kernel, maintained for bugfixes by Netgen.
https://netgen.io
Other
8 stars 18 forks source link

EZP-25100: Added common base for ContentCreateStruct / ContentUpdateStruct #35

Closed blankse closed 8 years ago

blankse commented 8 years ago

Original PR: https://github.com/ezsystems/ezpublish-kernel/pull/1504

emodric commented 8 years ago

Hi @blankse !

Thanks for this! However, is this really needed on 2014.11/12 ? As far as I understood, this is related to repo forms and Platform UI which does not work on this version anyhow. Are there any other usecases I'm not aware of?

blankse commented 8 years ago

Hi @emodric

  1. My PhpStorm shows me many erros because of the wrong property-write comments
  2. It's nice to have the ContentStruct class for Type Hinting in my Import Commands

I see no BC break. So why not? :)

emodric commented 8 years ago

Makes sense :) Do you want to implement other common objects for other create structs (in this or other PR)?

blankse commented 8 years ago

I added following PRs: https://github.com/ezsystems/ezpublish-kernel/pull/1398 https://github.com/ezsystems/ezpublish-kernel/pull/1408 https://github.com/ezsystems/ezpublish-kernel/pull/1429

Other useful classes such as ContentTypeStruct and FieldDefinitionStruct do not exist yet...

emodric commented 8 years ago

Thanks @blankse ! Give me couple of days to review and merge, please :)

emodric commented 8 years ago

P.S. There is a failing test now :)

blankse commented 8 years ago

It seems to be a time issue with publicationDate and modificationDate. I think it is not related to this changes. I try again.

emodric commented 8 years ago

Looks good, thanks :)