search

netgen / media-site-legacy

Variant of Netgen Media Site with Ibexa OSS and eZ Publish Legacy (Powered by Netgen Layouts)
Other
4 stars 5 forks source link

Swapped content class group ids in legacy injected_settings #3

Closed benkmugo closed 1 year ago

benkmugo commented 1 year ago

Hi @emodric

I was debugging some odd behaviour for the "Create new" menu in the admin interface, where the menu was showing options belonging to the wrong group e.g. showed media items while in the user groups subtree

It came down to the legacy settings having swapped ids from the "default". The default ids for the Media and Users for legacy installs I can see across our projects is: Users (2), Media (3)

Once I switched these two the issue was resolved. https://github.com/netgen/media-site-legacy/blob/82b0e5c222df20e84d148a345d17cace987a70de/config/app/packages/legacy.yaml#L54 https://github.com/netgen/media-site-legacy/blob/82b0e5c222df20e84d148a345d17cace987a70de/config/app/packages/legacy.yaml#L55

Could those setting be updated, or was there a reason for the swap?

Thanks, Ben

emodric commented 1 year ago

Hi, yes, this is because in our demo data, IDs are swapped, who knows why any more 😂

benkmugo commented 1 year ago

😂 good times. Maybe adding a comment just above that setting to make sure people check their actual IDs would be enough?

emodric commented 1 year ago

Sure. Mind creating a PR?

benkmugo commented 1 year ago

PR #4 is up now. Feel free to amend wording as you see fit.

Thanks again for providing the package and taking this on board.

emodric commented 1 year ago

Thanks Benjamin, merged the PR!