search

netgen / media-site

Netgen Media Site (Powered by Netgen Layouts & eZ Platform)
https://netgen.io
Other
30 stars 10 forks source link

NGSTACK-770 add 'important' to override ibexa's inline css #160

Closed draguna1 closed 11 months ago

draguna1 commented 11 months ago

Added !important to override Ibexa's inline css

emodric commented 11 months ago

@draguna1 Can you elaborate please what the issue is exactly, for future reference?

draguna1 commented 11 months ago

There were two different styles one was inline from Ibexa, and the other was implemented by Netgen. We had to override Ibexa's style by using the !important property.

emodric commented 11 months ago

That much is clear :) But what was the issue with ibexa inline css? What was displayed wrong because of it?

draguna1 commented 11 months ago

The problem was that the styles were displayed two times. For example, when we used unordered list two bullet would appear side by side.

Ljudevit commented 11 months ago

@emodric @draguna1 @kdraganic To explain in details:

for richtext unordered and ordered lists, we style them using pseudo :before elements for rendering bullets or numbers. Richtext has a functionality to include styles on each added unordered and ordered list, and by choosing any of the styles, the list is rendered with inline css "list-style-type" property, which overrides our cancellation of list style type, thus rendering lists with both "native" bullets and our pseudo bullets.

This quickfix will disable inline css from richtext options for unordered and ordered lists, basically removing the issue with double list bullets.

It is not optimal but it is definitely a quickfix until we decide on what we can do in the future with bullet styling.

emodric commented 11 months ago

Thanks @draguna1 !