netgen / summercamp-2015

Vagrant setup with Ansible provisioner configured for running Summer Camp 2015 virtual machine
https://2015.phpsummercamp.com
6 stars 10 forks source link

remove unused varnish-init.js overwrite file #12

Closed dbu closed 9 years ago

dbu commented 9 years ago

not that important, but in #10 you stop using this to overwrite. no need to provide the file.

vranac commented 9 years ago

Oh that file is used very much :) https://github.com/netgen/summercamp-2015/blob/master/provisioning/roles/varnish/tasks/main.yml#L16

dbu commented 9 years ago

no, you use varnish-defaults.j2 there, not varnish-init.js2

i remove only the file you removed from the ansible file in #10

vranac commented 9 years ago

The file was just renamed, from varnish-init.j2 to varnish-defaults.j2 in https://github.com/netgen/summercamp-2015/commit/d62f8dad4bc6e5eb34be76c0fc7d881d305fed1f after you opened the issue

dbu commented 9 years ago

ah, ok. and now i also see why things did not work before...