Instance controller: remove generation changed predicate

[giorio94]

Description

This PR removes the generation changed predicate from the instance controller, since it is the likely culprit for the status glitch observed during the exam simulation, as it might prevent the status from being correctly updated in case of race conditions.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

• [x] Automated tests
• [x] Staging environment

[kingmakerbot]

Hi @giorio94. Thanks for your PR.

I am @kingmakerbot. You can interact with me issuing a slash command in the first line of a comment. Currently, I understand the following commands:

• /rebase: Rebase this PR onto the master branch
• /merge: Merge this PR into the master branch
• /hold: Adds hold label to prevent merging with /merge
• /unhold: Removes the hold label to allow merging with /merge
• /deploy-staging: Deploy a staging environment to test this PR
• /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

• kind/breaking: :boom: Breaking Change
• kind/feature: :rocket: New Feature
• kind/bug: :bug: Bug Fix
• kind/cleanup: :broom: Code Refactoring
• kind/docs: :memo: Documentation

[giorio94]

/rebase

[QcFe]

/deploy-staging

[kingmakerbot]

Your staging environment has been correctly deployed/updated! Available here: Frontend, Storybook, Qlkube Operators: add the crownlabs.polito.it/operator-selector=staging-718 label to your tenant.

[QcFe]

/merge

[kingmakerbot]

Your staging environment has been correctly teared-down!