netgroup-polito / CrownLabs

Kubernetes-based Remote Laboratories
https://crownlabs.polito.it
Apache License 2.0
107 stars 42 forks source link

Metered Websockify + integrated NoVNC #749

Closed QcFe closed 2 years ago

QcFe commented 2 years ago

Description

This PR refactors the way the "frontend" part of container based instances works. Instead of having a single noVNC deployment, the websockify component has been rewritten in Go (leveraging the original basic version provided by the novnc team) and directly exposes a novnc deployment for each instance.

Between the improvements, this version of websockify includes Prometheus support for latency metrics (per each connection) and logging information.

kingmakerbot commented 2 years ago

Hi @QcFe. Thanks for your PR.

I am @kingmakerbot. You can interact with me issuing a slash command in the first line of a comment. Currently, I understand the following commands:

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

QcFe commented 2 years ago

/deploy-staging

QcFe commented 2 years ago

/deploy-staging

kingmakerbot commented 2 years ago

Your staging environment has been correctly deployed/updated! Available here: Frontend, Storybook, Qlkube Operators: add the crownlabs.polito.it/operator-selector=staging-749 label to your tenant.

QcFe commented 2 years ago

/hold

QcFe commented 2 years ago

/deploy-staging

kingmakerbot commented 2 years ago

Your staging environment has been correctly deployed/updated! Available here: Frontend, Storybook, Qlkube Operators: add the crownlabs.polito.it/operator-selector=staging-749 label to your tenant.

QcFe commented 2 years ago

/deploy-staging

kingmakerbot commented 2 years ago

Your staging environment has been correctly deployed/updated! Available here: Frontend, Storybook, Qlkube Operators: add the crownlabs.polito.it/operator-selector=staging-749 label to your tenant.

QcFe commented 2 years ago

/deploy-staging

kingmakerbot commented 2 years ago

Your staging environment has been correctly deployed/updated! Available here: Frontend, Storybook, Qlkube Operators: add the crownlabs.polito.it/operator-selector=staging-749 label to your tenant.

QcFe commented 2 years ago

/deploy-staging

kingmakerbot commented 2 years ago

Your staging environment has been correctly deployed/updated! Available here: Frontend, Storybook, Qlkube Operators: add the crownlabs.polito.it/operator-selector=staging-749 label to your tenant.

QcFe commented 2 years ago

/deploy-staging

kingmakerbot commented 2 years ago

Your staging environment has been correctly deployed/updated! Available here: Frontend, Storybook, Qlkube Operators: add the crownlabs.polito.it/operator-selector=staging-749 label to your tenant.

QcFe commented 2 years ago

/deploy-staging

kingmakerbot commented 2 years ago

Your staging environment has been correctly deployed/updated! Available here: Frontend, Storybook, Qlkube Operators: add the crownlabs.polito.it/operator-selector=staging-749 label to your tenant.

QcFe commented 2 years ago

/merge

QcFe commented 2 years ago

/merge

QcFe commented 2 years ago

/unhold

QcFe commented 2 years ago

/merge

kingmakerbot commented 2 years ago

Your staging environment has been correctly teared-down!