Closed QcFe closed 2 years ago
Hi @QcFe. Thanks for your PR.
I am @kingmakerbot. You can interact with me issuing a slash command in the first line of a comment. Currently, I understand the following commands:
/rebase
: Rebase this PR onto the master branch/merge
: Merge this PR into the master branch/hold
: Adds hold label to prevent merging with /merge/unhold
: Removes the hold label to allow merging with /merge/deploy-staging
: Deploy a staging environment to test this PR/undeploy-staging
: Manually undeploy the staging environmentMake sure this PR appears in the CrownLabs changelog, adding one of the following labels:
kind/breaking
: :boom: Breaking Changekind/feature
: :rocket: New Featurekind/bug
: :bug: Bug Fixkind/cleanup
: :broom: Code Refactoringkind/docs
: :memo: Documentation/deploy-staging
/deploy-staging
/hold
/deploy-staging
/deploy-staging
/deploy-staging
/deploy-staging
/deploy-staging
/deploy-staging
/merge
/merge
/unhold
/merge
Your staging environment has been correctly teared-down!
Description
This PR refactors the way the "frontend" part of container based instances works. Instead of having a single noVNC deployment, the websockify component has been rewritten in Go (leveraging the original basic version provided by the novnc team) and directly exposes a novnc deployment for each instance.
Between the improvements, this version of websockify includes Prometheus support for latency metrics (per each connection) and logging information.