netgroup-polito / CrownLabs

Kubernetes-based Remote Laboratories
https://crownlabs.polito.it
Apache License 2.0
107 stars 42 forks source link

Student insertion from csv: fix issue with (**) #817

Closed giorio94 closed 2 years ago

giorio94 commented 2 years ago

Description

This PR fixes an issue concerning students' insertion from CSV, which occurs when the surname contains the (**) string (used by the portal to signal certain conditions). This includes the frontend, to appropriately remove it, and the backend, to prevent issues with names that end with a space (after the removal of invalid characters).

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

giorio94 commented 2 years ago

/deploy-staging

kingmakerbot commented 2 years ago

Hi @giorio94. Thanks for your PR.

I am @kingmakerbot. You can interact with me issuing a slash command in the first line of a comment. Currently, I understand the following commands:

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

giorio94 commented 2 years ago

/deploy-staging

kingmakerbot commented 2 years ago

Your staging environment has been correctly deployed/updated! Available here: Frontend, Qlkube Operators: add the crownlabs.polito.it/operator-selector=staging-817 label to your tenant.

giorio94 commented 2 years ago

/merge

kingmakerbot commented 2 years ago

Your staging environment has been correctly teared-down!