netgroup-polito / CrownLabs

Kubernetes-based Remote Laboratories

https://crownlabs.polito.it

Apache License 2.0

107 stars 42 forks source link

Remove nextcloud #833

Closed matteorosani closed 1 year ago

matteorosani commented 1 year ago

Description

In this pull request we aim at removing the NextCloud service because not used anymore after the introduction of personal NFS storage.

kingmakerbot commented 1 year ago

Hi @matteorosani. Thanks for your PR.

I am @kingmakerbot. You can interact with me issuing a slash command in the first line of a comment. Currently, I understand the following commands:

/rebase: Rebase this PR onto the master branch
/merge: Merge this PR into the master branch
/hold: Adds hold label to prevent merging with /merge
/unhold: Removes the hold label to allow merging with /merge
/deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
/undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

kind/breaking: :boom: Breaking Change
kind/feature: :rocket: New Feature
kind/bug: :bug: Bug Fix
kind/cleanup: :broom: Code Refactoring
kind/docs: :memo: Documentation

frisso commented 1 year ago

@QcFe How do we handle this PR? If we merge the PR, we should also update all the images for VMs and containers, and update the dashboard, isn't it?

QcFe commented 1 year ago

With the previous NFS-related PR we already are in an unstable/undeployable configuration. We'll need at least one more PR for the frontend and indeed to rebuild all the VM images. Containers need no rebuild since they didn't use NextCloud.

frisso commented 1 year ago

Thanks, @QcFe . Please go the way you think is the best.

QcFe commented 1 year ago

@matteorosani reporting here too, just to keep track, found some more stuff to be cleaned:

in deploy/crownlabs/values.yaml there are still some NC parameters
remove infrastructure/file-sharing
some params quoted still in operators/README.md

QcFe commented 1 year ago

@cannarelladev would you mind doing a check on the frontend and removing the myDrive button and references? I fear we'll need to wait to deploy the new CRDs (without the myDrive) in order to have the typescript generator thingy to forget about it, but if we start to remove references it should break a bit less once we remove them...

QcFe commented 1 year ago

/merge