Tenant ctrl: automatically delete namespace after timeout

[giorio94]

Description

This PR aggregates the modifications originally proposed in #821 (by @rs59) and #827 (by @QcFe), and preserved in the corresponding commits. Additionally, it introduces a set of minor improvements, as well as of dedicated tests.

Supersedes: #821, #827

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

• [x] Automated tests
• [x] Staging environment

[kingmakerbot]

Hi @giorio94. Thanks for your PR.

I am @kingmakerbot. You can interact with me issuing a slash command in the first line of a comment. Currently, I understand the following commands:

• /rebase: Rebase this PR onto the master branch
• /merge: Merge this PR into the master branch
• /hold: Adds hold label to prevent merging with /merge
• /unhold: Removes the hold label to allow merging with /merge
• /deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
• /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

• kind/breaking: :boom: Breaking Change
• kind/feature: :rocket: New Feature
• kind/bug: :bug: Bug Fix
• kind/cleanup: :broom: Code Refactoring
• kind/docs: :memo: Documentation

[giorio94]

/deploy-staging

[kingmakerbot]

Your staging environment has been correctly deployed/updated! Available here: Frontend, Qlkube Operators: add the crownlabs.polito.it/operator-selector=staging-834 label to your tenant.

[giorio94]

/deploy-staging

[kingmakerbot]

Your staging environment has been correctly deployed/updated! Available here: Frontend, Qlkube Operators: add the crownlabs.polito.it/operator-selector=staging-834 label to your tenant.

[giorio94]

@QcFe I've rebased this PR, solving the conflicts introduced by the new MyDrive feature and the removal of the old one. Before merging, please give it a try in the staging environment, to make sure everything still works properly.

[QcFe]

Thank you so much @giorio94, will go through tests on monday hopefully

[QcFe]

/rebase

[QcFe]

/deploy-staging

[kingmakerbot]

Your staging environment has been correctly deployed/updated! Available here: Frontend, Qlkube Operators: add the crownlabs.polito.it/operator-selector=staging-834 label to your tenant.

[QcFe]

@giorio94 Sorry for the impossible delay. It seems there's a mismatch between the tenant cmd/main and the helm: the flag from helm is tenant-ns-keep-alive but the expected flag is tenant-operator-ns-keep-alive. I'll proceed with manual fix on the deployed staging to see everything else is correct

[giorio94]

@giorio94 Sorry for the impossible delay. It seems there's a mismatch between the tenant cmd/main and the helm: the flag from helm is tenant-ns-keep-alive but the expected flag is tenant-operator-ns-keep-alive. I'll proceed with manual fix on the deployed staging to see everything else is correct

I've updated the PR to make the flags match. I've opted for tenant-ns-keep-alive, since this is related to tenants themselves, and not to the tenant operator.

[QcFe]

/deploy-staging

[kingmakerbot]

Your staging environment has been correctly deployed/updated! Available here: Frontend, Qlkube Operators: add the crownlabs.polito.it/operator-selector=staging-834 label to your tenant.

[QcFe]

/merge

[kingmakerbot]

Your staging environment has been correctly teared-down!