netgroup-polito / CrownLabs

Kubernetes-based Remote Laboratories

https://crownlabs.polito.it

Apache License 2.0

107 stars 42 forks source link

Fix ssh keys being removed at login time #856

Closed QcFe closed 1 year ago

QcFe commented 1 year ago

Description

The copy-paste phenomenon made the manager key for the tenant update query that happens at login to match the one used during ssh keys update. This made ssh keys being deleted when the user first opened the dashboard (while setting the new lastLogin value).

QcFe commented 1 year ago

/deploy-staging

kingmakerbot commented 1 year ago

Hi @QcFe. Thanks for your PR.

I am @kingmakerbot. You can interact with me issuing a slash command in the first line of a comment. Currently, I understand the following commands:

/rebase: Rebase this PR onto the master branch
/merge: Merge this PR into the master branch
/hold: Adds hold label to prevent merging with /merge
/unhold: Removes the hold label to allow merging with /merge
/deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
/undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

kind/breaking: :boom: Breaking Change
kind/feature: :rocket: New Feature
kind/bug: :bug: Bug Fix
kind/cleanup: :broom: Code Refactoring
kind/docs: :memo: Documentation

kingmakerbot commented 1 year ago

Something went wrong while deploying your staging environment!

QcFe commented 1 year ago

/deploy-staging

kingmakerbot commented 1 year ago

Something went wrong while deploying your staging environment!

kingmakerbot commented 1 year ago

Something went wrong while deploying your staging environment!

air-31 commented 1 year ago

/deploy-staging

kingmakerbot commented 1 year ago

Something went wrong while deploying your staging environment!

air-31 commented 1 year ago

/deploy-staging

kingmakerbot commented 1 year ago

Something went wrong while deploying your staging environment!

kingmakerbot commented 1 year ago

Something went wrong while deploying your staging environment!

QcFe commented 1 year ago

/deploy-staging

kingmakerbot commented 1 year ago

Your staging environment has been correctly deployed/updated! Available here: Frontend, Qlkube Operators: add the crownlabs.polito.it/operator-selector=staging-856 label to your tenant.

QcFe commented 1 year ago

/merge

kingmakerbot commented 1 year ago

Your staging environment has been correctly teared-down!