netgroup-polito / CrownLabs

Kubernetes-based Remote Laboratories
https://crownlabs.polito.it
Apache License 2.0
107 stars 42 forks source link

Fix SSH key deletion error bug #914

Closed Mattia013 closed 6 days ago

Mattia013 commented 1 week ago

Description

Fix delete modal to prompt for the specific SSH key record in table.

When multiple SSH keys are available and we try to remove one, it is always prompted to remove the last one. This should fix this undesired behavior.

How Has This Been Tested?

The test was done recreating the SSHKeysTable in a new React Typescript project.

kingmakerbot commented 1 week ago

Hi @Mattia013. Thanks for your PR.

I am @kingmakerbot. You can interact with me issuing a slash command in the first line of a comment. Currently, I understand the following commands:

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

frisso commented 1 week ago

Thanks @Mattia013 for this contribution! @QcFe This looks very good to me. If you agree, we can approve and merge. Thanks to you both!

QcFe commented 1 week ago

/deploy-staging

kingmakerbot commented 1 week ago

Your staging environment has been correctly deployed/updated! Available here: Frontend, Qlkube Operators: add the crownlabs.polito.it/operator-selector=staging-914 label to your tenant.

QcFe commented 6 days ago

/merge

kingmakerbot commented 6 days ago

Your staging environment has been correctly teared-down!