search

netgroup-polito / edge-infrastructure-ansible

Collection of procedures to apply to setup and edge infrastructure for cloud continuum
Other
0 stars 3 forks source link

K3S Installation script #8

Closed giovannimirarchi420 closed 2 months ago

frisso commented 2 months ago

@giovannimirarchi420 It looks very good to me. Some (minor) comments to carry out, then we're ready to merge.

fracappa commented 2 months ago

Hi @giovannimirarchi420!

Thanks for your PR!

I added some comment on the management user creation part, inside the bash script you provided.

We should design it carefully as it is a user that should be accessed remotely and as such it would require having a password.

Moreover, I kindly ask you to squash the commits once we have a final version of your code so we can marge it by having only a single commit ahead w.r.t. the main branch.

Thanks! Francesco

frisso commented 2 months ago

@giovannimirarchi420 @fracappa It looks good to me, with just one note. We're cloning the Git repository here in this script, which means we need to have git installed in the mini-pc. Is this really needed? I would prefer to just download the repository, and run the scripts, without cloning. I don't expect the user has to modify the repo locally.

giovannimirarchi420 commented 2 months ago

@frisso @fracappa Git should most likely be pre-installed in ubuntu-server. However, here are a few ideas:

However, the "zipped" solution might make sense if git isn't pre-installed with the OS.

frisso commented 2 months ago

@giovannimirarchi420 I like the "zip" approach. Simply download the repo, such as https://github.com/netgroup-polito/edge-infrastructure-ansible/archive/refs/heads/main.zip , unzip, install, and remove it from the mini-pc.

fracappa commented 2 months ago

Hi @giovannimirarchi420 . Thanks for your contribution!

We would like to merge your changes into our repository but I would kindly ask you to squash the commits before merging,

Thanks!