search

netgroup-polito / frog4-migration-orch

Orchestrator that manages the mobility of VNFs
1 stars 0 forks source link

Endpoint embedded in javascript code #2

Open frisso opened 7 years ago

frisso commented 7 years ago

In file frog4-migration-orch/web_gui/static/js/functions.js

there's the following code at line 5: migration_orch_endpoint = "http://127.0.0.1:8083/v1

Shouldn't this be in a config file or so?

piscoroma commented 7 years ago

Yes, you are right. I wrote it during the tests and i forgot to move it.

Il 02/Lug/2017 15:29, "Fulvio Risso" notifications@github.com ha scritto:

In file frog4-migration-orch/web_gui/static/js/functions.js

there's the following code at line 5: migration_orch_endpoint = "http://127.0.0.1:8083/v1

Shouldn't this be in a config file or so?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/netgroup-polito/frog4-migration-orch/issues/2, or mute the thread https://github.com/notifications/unsubscribe-auth/AMBlq1N9KNAD1l3sX5WcIVLXKyp_pslzks5sJ5tGgaJpZM4OLlYF .

ivanocerrato commented 7 years ago

Is this issue fixed now?

piscoroma commented 7 years ago

Fixed.

frisso commented 7 years ago

@piscoroma : in fact, data is still "embedded" in file "appConfig.js". Never mind, please just tell people that there's this file with this data by writing a proper section in the main README.md file.

piscoroma commented 7 years ago

I know, in fact i tried to put the configuration in a .json rather than in a .js but it was not easy because in javascript the reading of a json file is asyncronus. So i chose to put in a .js that was easier. Anyway ok, i'm writing about it in the readme.

Il 12/Lug/2017 00:23, "Fulvio Risso" notifications@github.com ha scritto:

@piscoroma https://github.com/piscoroma : in fact, data is still "embedded" in file "appConfig.js". Never mind, please just tell people that there's this file with this data by writing a proper section in the main README.md file.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/netgroup-polito/frog4-migration-orch/issues/2#issuecomment-314589353, or mute the thread https://github.com/notifications/unsubscribe-auth/AMBlq6wEYT6A5iFqsUg3GfFNvwFT6PGYks5sM_XagaJpZM4OLlYF .

frisso commented 7 years ago

The problem, to my eyes, is not that you added the config in a .js. The biggest problem is that the file cannot be easily located. But, never mind, just document it and it's ok. Thanks.