debug mode

[ivanocerrato]

Why do we have two "debug" fields in the configuration file ?

• debug_mode https://github.com/netgroup-polito/frog4-openstack-do/blob/master/config/default-config.ini#L28
• debug https://github.com/netgroup-polito/frog4-openstack-do/blob/master/config/default-config.ini#L80

There exist any difference? Can we use some more meaningful name?

[ReliableLion]

The debug_mode enables debugging mode. The debug option specify the log level. I changed the second one, and updated the relative config.py, in a more meaningful name: debug_level

[ivanocerrato]

Now we have:

• debug_mode
• debug_level I think that the two terms are not clean yet.

I would call this https://github.com/netgroup-polito/frog4-openstack-do/blob/master/config/default-config.ini#L28 "fake_running", while I would call the second "debug_mode".

[ReliableLion]

Yes it would be better, even if the second should specify the log level. Maybe a single option it's better: Now:

• debug_level
• verbose_level Then:
• log_level: debug/verbose

[ivanocerrato]

I don't understand your proposal

[ivanocerrato]

Yesterday we noted that this field https://github.com/netgroup-polito/frog4-openstack-do/blob/master/config/default-config.ini#L26-L28 does not have any effect when set to true. Then I propose to remove it from the configuration file, and then to delete its usage from the code.

@rbrtbnfgl or @ReliableLion , can one of you take care of this issue?

[rbrtbnfgl]

If it is enabled it increase the information stored on a file and will always returned true only when the graph status is requested.

[ivanocerrato]

Well, then please remove it. Imho it is completely useless.

[ReliableLion]

I used the field also to write the flows in a file for debugging. Beyond that, that field was used as Roberto said. So I could remove it.

[ivanocerrato]

If also @rbrtbnfgl agrees, you can remove that flag.

To me, the code to print flows on files in very useful. You can enable it in case this flag here https://github.com/netgroup-polito/frog4-openstack-do/blob/master/config/default-config.ini#L80 is verbose (i then agree with your previous suggestion).

[ReliableLion]

Ok, so I'll remove the debug_mode field and then leave only a "log_level". The latter if is set to verbose will print the flows in a file, is that right?

[ivanocerrato]

The latter will do what it is already doing now + it will print the flows in a file.

@rbrtbnfgl do you agree?

[ivanocerrato]

@ReliableLion please proceed. Roberto just told me that he agrees.

[ReliableLion]

Ok I deleted the debug_mode field and used the debug_level field to print the flows in a file.

[ivanocerrato]

Just a detail: can you replace debug_level with debug_mode?

[ReliableLion]

Yes Done.

[ivanocerrato]

Then I close the issue.