search

netgroup-polito / frog4-orchestrator

FROG4 - Overarching orchestrator submodule
1 stars 0 forks source link

Bug in returned graph id #10

Closed piscoroma closed 7 years ago

piscoroma commented 7 years ago

When the graph is deployed, the returned id is not always correct. If the id starts with '0', the first zero is truncated. For example: the graph id is: 09234, the put of the graph returns 9234. The bug doesn't appear into the get of all graphs, but only in the put of a graph.

frisso commented 7 years ago

In fact, we should avoid "ids" and move to "uuid", which are becoming the stardard now: https://en.wikipedia.org/wiki/Universally_unique_identifier

farmanullahcs commented 7 years ago

closed with e0c829

farmanullahcs commented 7 years ago

The returned graph id example, when the graph is deployed. Is it correct ?

{ "nffg-uuid": "234204629483067032512745790389581325528" }

frisso commented 7 years ago

Can we return the uuid as a string, with the proper formatting rules, which makes much easier to read?

farmanullahcs commented 7 years ago

Which one is more suitable? or to improve proper formatting

{ "nffg-uuid": "6a188b06-3786-4c38-9a2c-4a75c1910975" }

{ "nffg-uuid": "3014c6f1039c4aea9cc17a046b20f197" }

frisso commented 7 years ago

Personally, I've always seen the former. And I like it better too.