search

netgroup-polito / frog4-orchestrator

FROG4 - Overarching orchestrator submodule
1 stars 0 forks source link

southbound API #11

Closed ivanocerrato closed 7 years ago

ivanocerrato commented 7 years ago

The southbound API of the FROG orchestrator towards the domain orchestrators should be changed. It must be the same already implemented between the GUI and the FROG orchestrator.

gabrielecastellano commented 7 years ago

Think this issue can be closed now? Cannot it?

ivanocerrato commented 7 years ago

I don't know. @farmanullahcs is this issue solved? If yes, is it in a specific branch?

farmanullahcs commented 7 years ago

Southbound API is not yet implemented, currently we have Put API like {Domain_Orchestrator_Address/NF-FG/graph-id}.

The new put api should be: 1) Put api for insertion {Domain_Orchestrator_Address/NF-FG/} 2) Put api for updating {Domain_Orchestrator_Address/NF-FG/graph-id}

Moreover, the graph id will be assigned by the Domain-Orchestrator and the graph id will be deleted from the graph json.

frisso commented 7 years ago

I'm confused. Shouldn't we use "put" for creation, and "post" for update?

ivanocerrato commented 7 years ago

Note that the comment from @frisso is valid for each orchestrator.

farmanullahcs commented 7 years ago

As far as I know,

1) "POST" api for creation {Domain_Orchestrator_Address/NF-FG/} 2) "PUT" api for update {Domain_Orchestrator_Address/NF-FG/graph-id}

Is it correct ?

frisso commented 7 years ago

Yes, Farman, I wrote the wrong way. POST for creation, PUT for update. Thanks for pointing this out.

farmanullahcs commented 7 years ago

Fixed in the branch frog4-deployment