search

netgroup-polito / un-orchestrator

Universal Node Orchestrator
Other
21 stars 13 forks source link

Native functions cleanup #106

Open frisso opened 8 years ago

frisso commented 8 years ago

(sorry for the Italian here) Leaving this open as a reminder, as Roberto is on holiday and we need to fix those issues.

https://github.com/netgroup-polito/un-orchestrator/blob/master/orchestrator/compute_controller/plugins/native/scripts/pullAndRunNativeNF_ns.sh#L132 come mai non lanci lo script in back ground? E se non ritorna? Lo universal node orchestrator rimarrebbe piantato li. Secondo me lo script dovrebbe essere lanciato in background.. Ti torna?

Inoltre ci sono due script nella cartella, che hanno lo stesso nome ma uno termina co "_ns". Vedendo il codice, questo mette le native nel namespace, l'altro no, e credo sia una cosa vecchia. Se cosi' e', posso cancellare questi script vecchi?

ivanocerrato commented 8 years ago

@rbrtbnfgl are you sure that this is correct?

https://github.com/netgroup-polito/un-orchestrator/blob/stable/orchestrator/compute_controller/plugins/native/scripts/pullAndRunNativeNF_ns.sh#L132

You only change the network namespace with this command. Then, you use it to execute for example ls, you list the files in the directory containing the un-orchestrator binary. Is this what you want?

ivanocerrato commented 7 years ago

@rbrtbnfgl is this issue solved?

ivanocerrato commented 7 years ago

@rbrtbnfgl what is the status of this issue?