Buildsystem improvements

netgroup-polito / un-orchestrator

Universal Node Orchestrator

Other

21 stars 13 forks source link

Buildsystem improvements #90

Closed thz closed 8 years ago

thz commented 8 years ago

cmake externalproject for json-spirit
cmake externalproject for libvirt
cmake externalproject for inih
mitigate cross-compilation pain
fix cmake use in various places

mauriciovasquezbernal commented 8 years ago

I like the approach, there is a minor detail in the CMakeList for the orchestrator. When Inih is added as an external project, the URL is set as " ${CMAKE_SOURCE_DIR}/contrib/inih-r35.zip". This configuration only works when the global cmake is executed, I mean, If I execute cmake inside the orchestrator it will fail because the path is wrong. I'd propose to use "${CMAKE_SOURCE_DIR}/../contrib/inih-r35.zip" as path, it works in both cases.

What do you think?