search

netgroup-polito / un-orchestrator

Universal Node Orchestrator
Other
21 stars 13 forks source link

json parser fails to detect some bad formatted nf-fgs #95

Open mauriciovasquezbernal opened 8 years ago

mauriciovasquezbernal commented 8 years ago

When there is a missing comma in the rules list on a NF-FG file, it is still considered valid but all the rules after the missing comma are ignored.

example:

{"id":"00000199", "match":{"port":"dpdk1"}, "action":{"VNF_id":"502_forwarder:2"} }, {"id":"00000200", "match":{"VNF_id":"501_forwarder:1"}, "action":{"VNF_id":"500_forwarder:2"} } {"id":"00000201", "match":{"VNF_id":"502_forwarder:1"}, "action":{"VNF_id":"501_forwarder:2"} }, {"id":"00000300", "match":{"VNF_id":"500_forwarder:1"}, "action":{"port":"dpdk0"} }

In this case all the rules from 200 are ignored.

ivanocerrato commented 8 years ago

@mvbpolito this is a problem of json spirit, not of the un-orchestrator.. I would propose to remove this issue.

mauriciovasquezbernal commented 8 years ago

I am not totally sure about closing it. It is true that is it not fault of the UN node, but it affects the UN node behavior.

frisso commented 8 years ago

I agree with Mauricio. Let's keep it open.