netgum / archanova

Archanova monorepo
https://archanova.io/
19 stars 11 forks source link

Can't detect other tokens #58

Closed pedrouid closed 5 years ago

pedrouid commented 5 years ago

I used the getTokens and getToken method on the playground and I couldn't find the token I transferred to the active account.

accountAddress: 0x2AC21C80e9bA7f8FB21e18086D439ccdc9DE823A tokenAddress: 0x3615757011112560521536258c1E7325Ae3b48AE

However I could top up the virtual balance using the token contract address so this issue wasn't too critical. So when I query the accountVirtualBalances, I get the following response:

Screenshot 2019-08-12 17 26 16

The token contract address gets listed on the virtual balances but it doesnt identify the name and symbol.

stanislaw-glogowski commented 5 years ago
  1. To get real (on-chain) balance of a token please use: https://playground.archanova.run/#get_token_balance
  2. getTokens and getToken methods are used to get informations about tokens which was added to virtual balance.
  3. symbol and name will be filled for tokens which implements ERC20Detailed from https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/ERC20Detailed.sol
stanislaw-glogowski commented 5 years ago

is this that token? https://rinkeby.etherscan.io/address/0x3615757011112560521536258c1E7325Ae3b48AE#code

stanislaw-glogowski commented 5 years ago

Issue was found. Name / symbol detection should works for future virtual balance operations.