search

netgum / archanova

Archanova monorepo
https://archanova.io/
19 stars 11 forks source link

Payable function error | Function requiring eth revert #67

Closed RyRy79261 closed 5 years ago

RyRy79261 commented 5 years ago

Description

A function which takes accepts eth in exchange for tokens, which returns any remaining eth sent, only reverts when the transaction is sent via Abridged & not remix or any ganache tests.

Network Sokol

RyRy79261 commented 5 years ago

Same transaction sent by Remix

https://blockscout.com/poa/sokol/tx/0xd946c273c4cfbd1db29982938cb00bd4fc01b8b903fef327a4f085a116aa04b5/token_transfers

RyRy79261 commented 5 years ago

I'm able to send the transaction through if I increase the required sending value by 0.000001, this is not required when sending in remix.

RyRy79261 commented 5 years ago

The issue runs the risk of scaling as the volumes increase so arbitrarily increasing the values is not a solve.

RyRy79261 commented 5 years ago

Theres a possibility that the relayer is subtracting the gas from the value being sent which would explain the need to add more eth than the value would typically require.

@stanislaw-glogowski would this assumption be correct?

stanislaw-glogowski commented 5 years ago

@RyRy79261 Relayer gets refund from account real balance no transaction value.