Branches in different format than KEY-XXX are parsed incorrectly - Githubissues

netguru / bitrise-step-slack

A next-gen Slack webhook step for Bitrise

https://netguru.co/opensource

MIT License

3 stars 0 forks source link

Branches in different format than KEY-XXX are parsed incorrectly #11

Closed rad3ks closed 8 years ago

rad3ks commented 8 years ago

Hi!

Let's consider such branch name: task/test-fix

The resulting Task part in slack message is being parsed incorrectly.

AS IS: [[["test", "fix"]]](https://url.domain/path/[["test", "fix"]])

My proposal is to omit Task segment when branch name doesn't allow to generate it properly.

TO BE: If the format of branch name is not branch/KEY-XXX we should not add Task segment to slack message.

I want to keep it as bug/enhancement proposal here and just discuss it.

I'm looking forward to see your responses

akashivskyy commented 8 years ago

👍, noticed that as well.

akashivskyy commented 8 years ago

Fixed in #12, released in 0.4.