search

netguru / bitrise-step-slack

A next-gen Slack webhook step for Bitrise
https://netguru.co/opensource
MIT License
3 stars 0 forks source link

Share in Bitrise StepLib? #8

Open viktorbenei opened 8 years ago

viktorbenei commented 8 years ago

We know about quite a few users who use your (awesome 😉) Slack step (and we do too 😎). Just wanted to ask whether you'd be open to share it in the StepLib.

We would be completely OK with having an alternative Slack step in the library, and based on the feedback & experience we gathered we do plan to provide better UI and support for step "alternatives" in the future.

The only requirement would be to pick an ID for the step which is distinct enough, something like formatted-slack would be more than enough.

Of course if you don't want to share it you don't have to, just wanted to ask as we referred your step for quite a few users now 😉

akashivskyy commented 8 years ago

Hi! We would be honored to have this in the standard StepLib! 😎

One question regarding the name – can we keep a bitrise-step- prefix in the name of this repository, so that the step would be called formatted-slack and point to netguru/bitrise-step-formatted-slack?

we do plan to provide better UI and support for step "alternatives" in the future.

Sounds amazing. 🍻

viktorbenei commented 8 years ago

Sure, you can pick any step ID, it doesn't have to be related to the step's github URL - in fact the step could be hosted on any other git service, and this also prevents repository renaming issues, the Step ID can remain constant regardless where the repository is :)

akashivskyy commented 8 years ago

Great! We'll rename the repository by Monday and I will ping you on Bitrise Slack once we're ready for sharing. 😉

viktorbenei commented 8 years ago

If you don't want to, you don't have to rename the repo either ;)

akashivskyy commented 8 years ago

I think it's good to be consistent with the StepLib name. However, renaming the repository would break existing integrations. 😕 So yeah, maybe you're right.

viktorbenei commented 8 years ago

In case of GitHub renames are usually fine, if you git clone the old URL GitHub will redirect it to the new URL properly, unless you reuse the old/current name.