#149 replace renderBody to children in predefined components

netguru / sticky-parallax-header

A simple React Native library, enabling the creation of fully customized header for your iOS and Android apps.

https://netguru.github.io/sticky-parallax-header/

MIT License

1.86k stars 190 forks source link

#149 replace renderBody to children in predefined components #167

Closed bobsany16 closed 3 years ago

bobsany16 commented 4 years ago

Replaced renderBody prop with children in AvatarHeader, DetailsHeader, and TabbedHeader (this one wasn't mention in the issue #149 but I thought it'd make sense that all 3 predefined components should be consistent)
Added the children prop in docs and index.d.ts

Note

I was unsure if I should have defined a defaultProp for children or not in all 3 headers. I saw that while renderBody had a defaultProp of <RenderContent user={} /> or <RenderContent title="" />
Please let me know if I should fix this 😁

pi0trpietruszewski commented 4 years ago

I believe we need pass default component. Without it there will be no content in scroll. @Patys what do you think?

bobsany16 commented 4 years ago

Will work on it! Been a bit busy

Patys commented 4 years ago

@bobsany16 So users should be able to update and it won't require any additional work for them to use new version, also if they use renderBody they should get yellow box warning about deprecation and moving to children

bobsany16 commented 4 years ago

@Patys was able to do what you asked, except for marking it deprecated. When researching, the ideal scenario is that we would declare the renderBody prop as deprecated but since this would likely console.warn(), this would fail tests. Any ideas ?

Tilenozz commented 4 years ago

When this feature will be avaiable ?