Closed Vn-ChemGio closed 2 years ago
@Vn-ChemGio could you fix lint issues before I can merge it?
106:8 error Delete `⏎········` prettier/prettier
109:31 error Replace `·leftTopIconAccessibilityLabel·` with `leftTopIconAccessibilityLabel` prettier/prettier
111:20 error Replace `·HIT_SLOP·` with `HIT_SLOP` prettier/prettier
112:20 error Replace `·leftTopIconOnPress·` with `leftTopIconOnPress` prettier/prettier
113:18 error Replace `·styles.leftHeaderButton·` with `styles.leftHeaderButton` prettier/prettier
114:19 error Replace `·leftTopIconTestID·` with `leftTopIconTestID` prettier/prettier
115:31 error Replace `·leftTopIcon·}` with `leftTopIcon}·` prettier/prettier
117:1 error Replace `········)·:·null⏎······` with `······)·:·null` prettier/prettier
132:8 error Replace `⏎········rightTopIcon·?⏎·······` with `rightTopIcon·?` prettier/prettier
135:1 error Delete `··` prettier/prettier
136:11 error Replace `··accessibilityLabel={·rightTopIconAccessibilityLabel·` with `accessibilityLabel={rightTopIconAccessibilityLabel` prettier/prettier
137:1 error Replace `············` with `··········` prettier/prettier
138:11 error Replace `··hitSlop={·HIT_SLOP·` with `hitSlop={HIT_SLOP` prettier/prettier
139:1 error Replace `············onPress={·rightTopIconOnPress·` with `··········onPress={rightTopIconOnPress` prettier/prettier
140:1 error Replace `············style={·styles.rightHeaderButton·` with `··········style={styles.rightHeaderButton` prettier/prettier
141:1 error Replace `············testID={·rightTopIconTestID·` with `··········testID={rightTopIconTestID` prettier/prettier
142:11 error Replace `··<IconRenderer·icon={·rightTopIcon·}` with `<IconRenderer·icon={rightTopIcon}·` prettier/prettier
143:9 error Delete `··` prettier/prettier
144:7 error Replace `··)·:·null⏎······` with `)·:·null` prettier/prettier
✖ 19 problems (19 errors, 0 warnings)
19 errors and 0 warnings potentially fixable with the `--fix` option.
Ok. @mateusz1913 mateusz1913 I also see some other issue and will fix
Thx @Vn-ChemGio , your fix is available in v1.0.0-rc.9 🚀
fix: After header collapse miss image in HeaderBar
fix: Remove redundant space in HeaderBar when leftTopIcon or rightTopIcon doesn't provider
This pull request resolves #356
Affected platforms
Test plan/screenshots/videos