#379 fix: safeAreaView compat with reanimated on web platform

netguru / sticky-parallax-header

A simple React Native library, enabling the creation of fully customized header for your iOS and Android apps.

https://netguru.github.io/sticky-parallax-header/

MIT License

1.86k stars 190 forks source link

#379 fix: safeAreaView compat with reanimated on web platform #380

Closed abbottdev closed 1 year ago

abbottdev commented 1 year ago

This pull request resolves #379

Description

Using expo web, the Reanimated library only supports class components not functional components. This pull request updates the signatures of downstream consumers to use ComponentClasses where required and also splits out the SafeAreaView from a standard Reanimated.View to ensure this can run on web. The sticky scrollbars continue to work on the web.

Affected platforms

[ ] Android
[ ] iOS
[x] Web

Gabrola commented 1 year ago

Looks cool! Fix comments and let's 🚢 it

@mateusz1913 needing this fix but seems like @abbottdev isn't active. Can you apply your code review changes yourself and merge this in please? Cheers

mateusz1913 commented 1 year ago

Closing in favor of #402

cc @Gabrola