feat: make web work without reanimated's babel/swc plugin

netguru / sticky-parallax-header

A simple React Native library, enabling the creation of fully customized header for your iOS and Android apps.

https://netguru.github.io/sticky-parallax-header/

MIT License

1.86k stars 190 forks source link

feat: make web work without reanimated's babel/swc plugin #395

Closed Gabrola closed 1 year ago

Gabrola commented 1 year ago

This pull request resolves #394

Description

Added dependency arrays to all of reanimated's hooks so sticky-parallex-header can work on web without having to use reanimated's babel/swc plugin. There were some hooks with incorrect/empty dependency arrays as well, I think this could possibly be the cause of #186

Affected platforms

[ ] Android
[ ] iOS
[x] Web

Test plan/screenshots/videos

Gabrola commented 1 year ago

Now there's no .eslintrc.js change at all 😃, the change you did for additional hooks before was valid, just do not change the code-styling inside 😅

Damn, my bad 😅 This was quite a while ago that I forgot I even made this change. Should be all good now.

mateusz1913 commented 1 year ago

It's available in version 1.1.0 🚀