search

netguru / sticky-parallax-header

A simple React Native library, enabling the creation of fully customized header for your iOS and Android apps.
https://netguru.github.io/sticky-parallax-header/
MIT License
1.86k stars 190 forks source link

refactor: move renderHeader from useDetailsHeader hook to DetailsHead… #398

Closed ilhamfadheel closed 1 year ago

ilhamfadheel commented 1 year ago

This pull request resolves the issue related to moving the renderHeader function from the useDetailsHeader hook to the DetailsHeaderScrollView props.

Description

The DetailsHeaderScrollView component had its renderHeader function inside the useDetailsHeader hook, which made it difficult to customize the header component. This pull request refactors the code to move renderHeader as a prop of the DetailsHeaderScrollView component.

Affected platforms

ilhamfadheel commented 1 year ago

still trying to squash, never done it before :/

mateusz1913 commented 1 year ago

@ilhamfadheel thx for your contribution, new version 1.0.2 is now available 🚀