search

netguy204 / imp.el

Impatient html mode. See your changes in the browser as you type
http://www.youtube.com/watch?v=QV6XVyXjBO8
137 stars 28 forks source link

doc.body.clientHeight -> document.body.clientHeight in chrome #8

Closed riaandewit closed 10 years ago

riaandewit commented 11 years ago

Hi there I'm not sure whether this is an actual issue, or I'm dense or something, but I was getting 500 errors when running impatient-mode.

Digging around a bit, I found references to doc.body.clientHeight were causing problems. Changing it to document.body.clientHeight sorted things out for me.

Not sure whether you want/need to change anything, but thought I'd let you know, to be on the safe side.

Thanks for a FANTASTIC system.

netguy204 commented 11 years ago

Maybe I'm being dense: What references to doc.body.clientHeight? I see no such references in the code base.

EDIT: Oops, yup. I'm the dense one. Do you get any script errors? doc is the document contained in the embedded iframe while document is the outer document. I think we want doc in this case.

500 errors are surprising! That's a server response and the details of scrolling shouldn't impact that.

netguy204 commented 11 years ago

Did you recently update impatient-mode from elpa? If so, try restarting emacs.

netguy204 commented 10 years ago

Resolved by #10