search

nethackscoreboard-org / matter

NetHack Scoreboard repo for live site
https://nethackscoreboard.org
MIT License
6 stars 6 forks source link

show first-to-ascend for spl #24

Closed RojjaCebolla closed 4 years ago

aoeixsz4 commented 4 years ago

Ok, so, unfortunately that won't quite work. NHS currently defines the abbreviation of SpliceHack to be "sph", but that's not the only problem. There is information missing from cfg/nethack_def.json, that needs to be fixed before I can merge this. I have added the missing roles and races for SpliceHack, but other data also need to be there to define what race/role/align combinations are possible in each variant - this is not yet there for SpliceHack. It doesn't actually make much sense to merge this PR tbh. However, you have successfully spurred me into making related changes. I'm also wondering how much of a pain it would be to change the scoreboard so it abbreviates SpliceHack as spl instead of sph. Seems like everyone else normally says spl (myself included), including the Beholder bot reporting on hardfought games.

aoeixsz4 commented 4 years ago

See commit 9391bbe. For the combinations, we'll need that information in there too. Either in the form of exclusion rules (as is done for vanilla and a few variants), or a full, explicit list of allowed combinations (EvilHack, dNethack). SLASH'EM, slex and dnhslex are permanently barred from consideration for first-to-ascend. Mandevil made this decision in the past with the older codebase, and I have no intention of changing that.

aoeixsz4 commented 4 years ago

well now I added all the stuff I shall pull your change and try to test it out. woop