nethesis / dev

Nethesis issue tracker
http://www.nethesis.it
4 stars 1 forks source link

NethCTI: error on phone urls with not escaped char #5998

Closed andrea-marchionni closed 3 years ago

andrea-marchionni commented 3 years ago

NethCTI server creates phone URL to use phone's API. This URL is made using web username and password of the phone, phone's IP, phone's account.

These values are separated in the URL by '@' or ':' chars.

An example of a URL is

http://username:password@IP/servlet?key=number=NUMBER_TO_CALL&outgoing_uri=EXTENSION@SERVER_SIP

If the password of the phone web user includes @ , the URL is generated badly because the @ in the password is read as password end.

A test replacing @ with %40 is successful.

alepolidori commented 3 years ago

Fixed on both requested:

alepolidori commented 3 years ago

How to test

with "automatic click2call" and "cloud click2call"

nethbot commented 3 years ago

in 7.9.2009/nethesis-testing:

nethbot commented 3 years ago

in 7.9.2009/nethesis-testing:

nethbot commented 3 years ago

in 7.9.2009/nethesis-testing:

nethbot commented 3 years ago

in 7.9.2009/nethesis-testing:

nethbot commented 3 years ago

in 7.9.2009/nethesis-testing:

nethbot commented 3 years ago

in 7.9.2009/nethesis-testing:

nethbot commented 3 years ago

in 7.9.2009/nethesis-testing:

nethbot commented 3 years ago

in 7.9.2009/nethesis-testing:

Stell0 commented 3 years ago

Proposed fix didn't resolve the problem and has been reverted. Also it isn't possibile to get relevant informations about this issue. The workaround is simply to avoid @ in phones password and also new provisioning doesn't have @ as default password for phones, therefore there is no point in fixing this. I'm closing it as WONTFIX

Stell0 commented 3 years ago

Solved in https://github.com/nethesis/dev/issues/6060