nethvoice-report-update FAILS at first install

[Stell0]

nethvoice-report-conf action checks if data_call table columns needs to be fixed and drop the table if the fix is needed (it will be created again the first night). But the action doesn't check if the table exists and at first install it does not. This prints some errors and make the action fail:

Nov 25 10:14:42 makako esmith::event[14113]: ERROR 1050 (42S01) at line 129: Table 'cost_details' already exists
Nov 25 10:14:46 makako esmith::event[14113]: Empty profile config
Nov 25 10:14:47 makako esmith::event[14113]: Please update your modules and reload Asterisk by browsing to your server.
Nov 25 10:14:47 makako esmith::event[14113]: ERROR 1146 (42S02) at line 1: Table 'asteriskcdrdb.data_call' doesn't exist
Nov 25 10:14:47 makako esmith::event[14113]: ERROR 1146 (42S02) at line 1: Table 'asteriskcdrdb.data_call' doesn't exist
Nov 25 10:14:47 makako esmith::event[14113]: ERROR 1051 (42S02) at line 1: Unknown table 'data_call'
Nov 25 10:14:47 makako esmith::event[14113]: Action: /etc/e-smith/events/nethvoice-report-update/S50nethvoice-report-conf FAILED: 1 [5.145547]
Nov 25 10:14:47 makako esmith::event[14113]: [INFO] service collectd restart
Nov 25 10:14:47 makako esmith::event[14113]: [INFO] service httpd reload
Nov 25 10:14:48 makako esmith::event[14113]: [INFO] service nethvoice-report-api restart
Nov 25 10:14:48 makako esmith::event[14113]: Action: /etc/e-smith/events/actions/adjust-services SUCCESS [0.960474]
Nov 25 10:14:48 makako esmith::event[14113]: Event: nethvoice-report-update FAILED

The package installation and the database aren't compromised by the errors

Steps to reproduce

• Install nethvoice-reports or delete data_call table and launch the nethvoice-report-update event
• check the log

Expected behavior

nethvoice-report-update should end with SUCCESS

Actual behavior

nethvoice-report-update FAILS

Components

nethvoice-report-1.0.5-1.ns7.x86_64

[nethbot]

in 7.9.2009/nethesis-testing:

• nethvoice-report-1.0.5-1.3.g65e0fac.ns7.x86_64.rpm x86_64
• nethvoice-report-debuginfo-1.0.5-1.3.g65e0fac.ns7.x86_64.rpm x86_64

[Stell0]

Test case:

• [make a snapshot] (useful later)
• make a new installation
• check that there aren't errors in /var/log/messages
• check that cost_details table exists
• [restore the snapshot]
• install released package (nethvoice-report-1.0.5-1.ns7.x86_64)
• launch nightly tasks su - asterisk -c "/opt/nethvoice-report/scripts/queue-miner.php && /opt/nethvoice-report/tasks/tasks cdr && /opt/nethvoice-report/tasks/tasks cost && /opt/nethvoice-report/tasks/tasks views && /opt/nethvoice-report/tasks/tasks queries"
• alter table data call to trigger the fix #6064 /usr/bin/mysql asteriskcdrdb -e "ALTER TABLE data_call DROP COLUMN agents"
• update package from testing
• check that data_call has been dropped
• check that there aren't errors in /var/log/messages

[nethbot]

in 7.9.2009/nethesis-updates:

• nethvoice-report-1.0.6-1.ns7.x86_64.rpm x86_64
• nethvoice-report-debuginfo-1.0.6-1.ns7.x86_64.rpm x86_64