nethesis / ns8-nethvoice

NethVoice: an Asterisk based PBX
GNU General Public License v3.0
0 stars 3 forks source link

remove checkUsermanIsUnlocked() #262

Open Stell0 opened 2 months ago

Stell0 commented 2 months ago

Instead of checking for userman syncing ad fail if it's locked, call the update low level function without checks.

If directory is syncing, it isn't possible to update extensions into userman table, so Wizard checks for userman directory lock before changing a mainextension. But syncing can take a lot of time and if there are a lot of users this make user page in wizard not usable.

Is lock checking really neded? If directory is locked, the updateUser function fails but why? In the cases of AD/LDAP, it shouldn't be really an issue because tue updateUser calls the driver updateUser that just update mysql.

So can we call driver updateUser without checking for syncing? it seems so.

This needs to be tested very well