netifi-proteus / proteus-java

Proteus Java Client
https://www.netifi.com
Apache License 2.0
42 stars 3 forks source link

Double Write of SeqId? #1

Closed kbahr closed 6 years ago

kbahr commented 6 years ago

https://github.com/netifi-proteus/proteus-java/blob/2d287cf0333fe2b175f448f1655fbe8e086fcd2b/frames/src/main/java/io/netifi/proteus/frames/AuthenticationResponseFlyweight.java#L35

Isn't the sequence ID written as part of the header? Is this redundant or is there something I missed on the authentication response frame such that it needs it twice?

robertroeser commented 6 years ago

we removed seq id