search

netifi-proteus / proteus-java

Proteus Java Client
https://www.netifi.com
Apache License 2.0
42 stars 3 forks source link

Compilation issues when using Spring Boot #5

Closed gregwhitaker closed 5 years ago

gregwhitaker commented 6 years ago

Issue

Currently, using proteus-java with Spring Boot causes compilation issues. Spring Boot is pulling in an incompatible version of Guava which overrides the version imported by proteus-java.

Solution

We need to shade guava in the proteus-java jars.

Current Workaround

You can force the dependency resolution in Gradle using the following, but it is ugly and not cool of us to ask people to add that to each of their spring-based proteus projects.

configurations.all {
    resolutionStrategy {
        dependencySubstitution {
            substitute module('com.google.guava:guava') with module('com.google.guava:guava:22.0')
        }
    }
}
liqweed commented 5 years ago

Any update on this?

gregwhitaker commented 5 years ago

@liqweed This has been fixed in the latest version of Proteus 1.5.3 which will be released later this week.

liqweed commented 5 years ago

@gregwhitaker That's great!

I'm trying to integrate Proteus and Guava 22.0 breaks our existing code. Also, I had to temporarily remove errorprone compiler plugin - it's not compatible with this version of Guava as well.

liqweed commented 5 years ago

Can this be closed?