search

netinvent / npbackup

A secure and efficient file backup solution that fits both system administrators (CLI) and end users (GUI)
GNU General Public License v3.0
141 stars 5 forks source link

full repo address shown at Operations. #64

Closed GuitarBilly closed 2 weeks ago

GuitarBilly commented 2 weeks ago

v3.0.0.1.rc1 https://github.com/netinvent/npbackup/releases/tag/v3.0.0-rc1

hello, I may miss a configuration item but after setting up a new repo and re-opening the config the URI and password are hidden by <encrypted>marks. So far so good.

However when I press on Operations button the full repo URI is shown. Now I can understand that it makes sense to show a repo URI to decide if it is really the one that you want to apply the operation on, especially with items like Prune and Forget.

But that does not match with the design philosophy of hiding sensitive information to the end user. What is your view on this?

configuration repo URI masked: afbeelding

Operations repo URI fully visible: afbeelding

deajan commented 2 weeks ago

Indeed, I just forgot to develop that part ^^ I'll make the URI secret as in the config. There's still right click show unencrypted when a password is set.

deajan commented 2 weeks ago

Added the same protection as in config window, including the right click.

You can try by installing the git master, or wait for a RC2 release which hopefully should happen somewhere in July. Feel free to re-open the issue if needed.