Closed aymenBox closed 1 year ago
Do you have a case where current functions did not return the office version even when installed ?
No but I work as an IT technician and I have seen when office is installed but not showing in software list wish happened to me a couple of times it means the office version is a hacked development version or a corrupted version and then MS office must be reinstalled, I think a simple solution can help at least in my situation also adding condition for office 365 can be checked like this.
sorry I misunderstood your question if you are talking about the current function then I'm using office 2021 Pro Plus and it's not showing I understand the code has to be updated but something that auto update and always work is better.
Since your patch adresses corner cases where Office was installed in a "hackish" or "dev" way, I prefer to not merge. Your case is well resolved by your actual code, but most people would want only "original" install detection.
Reference Issues/PRs
None
What does this implement/fix? Explain your changes.
the reason for this pull request is to add a better way to get the office version using the installed software package what usually needed when developing application with this library is to get the possible office version installed I know my code can be fixed and updated more but something like this is a better solution . example output
what is simply happening is that we use the installed software module to get list off software then we filter on any software with the string 'office' and 'Microsoft' combined in it.
Any other comments?
it's a great project hope to see it grow more.