netizen539 / civcraft

GNU General Public License v2.0
35 stars 64 forks source link

Mavenized and updated to 1.7.9 #23

Open vemacs opened 10 years ago

vemacs commented 10 years ago

My repo: https://github.com/vemacs/civcraft/

I'm going to fire up a test instance and try this out, but it compiles, is Mavenized and updated to 1.7.9 (v1_7_R3), and has BoneCP, etc... shaded into the JAR. You can directly import the parent pom.xml into Eclipse if you have the Eclipse for Java Developers version, otherwise, if you have the EE version, you'll need to install m2eclipse.

@minecrafter updated your patches to produce this JAR: http://cl.ly/ViO7/spigot.jar

All the JARs are under <name>/target, in case you're unfamiliar with maven.

In case you don't understand the need for mavenization, it makes compilation and updating much easier (a simple mvn clean install), and essentially all major Bukkit plugins use it. Bukkit itself uses it. This also removes the restriction to a single IDE (I can compile on IDEA, from a standard Linux server, etc...) and removes the need for putting many dependencies in the repo.

I can't PR it because:

If you want to merge it, you can try this: https://help.github.com/articles/syncing-a-fork

Here's the build log: http://paste.ubuntu.com/7507774/

rjdunlap commented 10 years ago

Thanks! We'll be looking at updating our servers soon! ~ObeliskGaming.net

KickinNick commented 10 years ago

Hey I'm trying to install your version after, compiling it and I keep getting this error http://pastebin.com/xXjjeVF4 any ideas?

-Edit- I think I might know whats wrong, i'm getting compiling errors, http://pastebin.com/Ytp4MxaL. As i'm not to advanced with Maven hopefully you could explain whats wrong. Oh i'm also using the Maven to Eclipse plugin.

vemacs commented 10 years ago

@KickinNick

[ERROR] No compiler is provided in this environment. Perhaps you are running on a JRE rather than a JDK?

See http://wiki.bukkit.org/Plugin_Tutorial#Deploying_your_Plugin

You have to use Maven to compile this, as it handles shading in BoneCP.

rjdunlap commented 10 years ago

Everything other than the vault version worked for me, changed it to 1.2.31

netizen539 commented 10 years ago

Hey vemacs, thanks for doing this! I'll see if I can get it integrated.

Updating to 1.7.9 is great, but keep in mind the anti-cheat client will only work for 1.7.2 util a new forge version comes out. IDK if anybody uses the client-side anti-cheat or not so it might be a moot point.

vemacs commented 10 years ago

@rjdunlap I've bumped the version in my repo, but the official Vault Maven Repo should contain 1.2.30...

@netizen539 Great to know!

githubnemo commented 10 years ago

I can verify that building with maven works with the freshly cloned civcraft repository of @vemacs.

Built with:

$ JAVA_HOME=/usr/lib/jvm/java-7-openjdk-amd64/jre/ mvn clean install

Great work, saved me much trouble with eclipse, thanks.

On a side note, it would've been nice to have everything wrapped up in a build directory from which the whole bunch can be executed/copied directly.

vemacs commented 10 years ago

@githubnemo Thanks for the confirm, but I really don't think that messing around with Maven output directories would be overly beneficial. Indeed, it might result in confusion for people who expect things done The Maven Way [TM].

githubnemo commented 10 years ago

@vemacs I don't know what The Maven Way™ is but having a ready to go server structure cannot be bad, can it? If not with maven, how about a (shell) script that invokes maven and copies the built files into the correct structure?

On a side note: Is it a known 1.7.9 issue or has it something to do with the build system that I cannot craft Tier 1 materials (or any CivCraft materials whatsoever)? 3x3 grid logs -> no Tier 1 refined wood. I tried standard spigot and the one you built.

vemacs commented 10 years ago

Updated to master thanks to @Supaham

KickinNick commented 10 years ago

@githubnemo I am getting the same error as well, http://pastebin.com/Kp9zQheW.