search

netizenorg / netnet.studio

netnet.studio is a hypermedia higherEd cyberspace for fully realizing the Web’s creative potential.
https://netnet.studio
GNU General Public License v3.0
30 stars 8 forks source link

Issue #237: close generated link #247

Closed Cthomp7 closed 6 months ago

Cthomp7 commented 10 months ago

Added this.$('[name="dem-url"]').style.display = 'none' to the end of the DEM _updateStep. This hides/closes the old generated link every time the example is updated or a new example is loaded in. #237

nbriz commented 9 months ago

@Cthomp7 this is ready to go as is, but what do u think about also adding that line at the bottom of the _addStep method? that way it closes as soon as the user adds a new line (even if technically the new step hasn't been saved yet).

nbriz commented 9 months ago

@Cthomp7 thoughts on my comment above?

Cthomp7 commented 9 months ago

@nbriz I don't think that's a bad idea. We can always remove later if need be. Let me add that quick.

Cthomp7 commented 9 months ago

@nbriz Just pushed and cleaned up the merge since there was a conflict. Conflict was just from newer reorderable list stuff in the _addStep method. Should be good to go!

nbriz commented 9 months ago

@Cthomp7 i pulled changes && now i'm getting an error soon as i open the widget (which seems to block most of the rest of the functionality from working, can't add steps or generate links, etc)

in Firefox:

TypeError: step is undefined
    _selectStep http://localhost:8001/widgets/demo-example-maker/index.js:300

in Chrome:

TypeError: Cannot read properties of undefined (reading 'title')
    at DemoExampleMaker._selectStep (index.js:299:49)
Cthomp7 commented 7 months ago

@nbriz I was looking into the issue you mentioned above and I was not able to recreate this. Would you be able to pull the newest version of this branch and let me know if you are still receiving this error? I merged the newest version of the DEM with the reorderable list to see if this issue appeared with the newest code and still no issues.

If you do still receive the error if you can explain what actions you took to create this error that would be greatly appreciated!😺

nbriz commented 6 months ago

hey @Cthomp7 after pulling the most recent changes, the error i was noticing before was gone... however there was another issue. but rather than discussing it here, i'm gonna explain on this thread ++ i'm gonna merge this && we can open up a new PR to fix it.