search

netkit-jh / netkit-jh-build

Build scripts for the kernel, filesystem and assisting scripts/programs for Netkit-JH.
https://netkit-jh.github.io/
GNU General Public License v3.0
22 stars 12 forks source link

removeLabFolder() may result in rm -rf / #58

Closed EdOverflow closed 2 years ago

EdOverflow commented 3 years ago

The removeLabFolder() is asking for trouble due to the use of rm -rf which is then called in multiple locations where it could end up wiping random files on the user's host machine.

https://github.com/netkit-jh/netkit-jh-build/blob/209af1bb8be8b2660b9b35a6d0c77ce350b09c16/core/bin/lcommon#L124-L132

I would suggest using a safer approach.

AdamBromiley commented 2 years ago

Issue has been resolved in version 2.0.0-beta.