search

netlify-labs / react-netlify-identity

a tiny (4kb) React hook for using Netlify Identity, no UI. SEEKING MAINTAINERS
https://netlify-gotrue-in-react.netlify.com/
156 stars 25 forks source link

Added example #18

Closed lewislbr closed 4 years ago

lewislbr commented 4 years ago

Hi there,

First of all, thanks for this great work, it's exactly what I was looking for!

I've added an example adapted from a recent implementation I did of this package with React Router, I thought I could share it so it may help somebody. I've moved the existing example and this one into a new examples folder.

If anything can be improved please let me know.

Cheers!

swyxio commented 4 years ago

thanks v much! can you tweak the readme to make it obvious the differences between the examples? as a rule you want to spell it out for the next user who comes along. also instead of naming folders "example1" "example2", name them something a little more obvious. make a call on what that is but you can do better than 1 and 2

lewislbr commented 4 years ago

Sure! Please check the changes and let me know what you think

swyxio commented 4 years ago

excellent :) thank you very much