search

netlify / angular-runtime

The Angular Runtime allows Angular to run on Netlify with zero configuration
https://docs.netlify.com/integrations/frameworks/angular/
MIT License
19 stars 11 forks source link

fix missing .netlify/edge-functions/angular-ssr #106

Closed hrishikesh-k closed 5 months ago

hrishikesh-k commented 5 months ago

Reported in the forums: https://answers.netlify.com/t/116319/

I was able to reproduce as well. Turns out @netlify/build already clears that directory here: https://github.com/netlify/build/blob/main/packages/build/src/plugins_core/pre_dev_cleanup/index.ts#L18-L42, so this plugin should not have to do anything.

netlify[bot] commented 5 months ago

Deploy Preview for plugin-angular-universal-demo ready!

Name Link
Latest commit 7a1c3f4d3ecaa133a6f38239a9fe1c86021a2e84
Latest deploy log https://app.netlify.com/sites/plugin-angular-universal-demo/deploys/66225e174c53390008379cb5
Deploy Preview https://deploy-preview-106--plugin-angular-universal-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hrishikesh-k commented 5 months ago

What's the release cycle for this? Do we need to manually publish to npm or something?

Skn0tt commented 5 months ago

I think so - release-please should do it automatically, but the PR was missing the right title I believe. could you open another PR with an empty commit, and name the PR fix: trigger release for previous PR or something?

hrishikesh-k commented 5 months ago

Done: https://github.com/netlify/angular-runtime/pull/107

Skn0tt commented 5 months ago

we did it! https://github.com/netlify/angular-runtime/pull/109