netlify / angular-runtime

The Angular Runtime allows Angular to run on Netlify with zero configuration
https://docs.netlify.com/integrations/frameworks/angular/
MIT License
19 stars 11 forks source link

feat: add basic support for angular universal #5

Closed lindsaylevine closed 3 years ago

lindsaylevine commented 3 years ago

This PR adds the minimum level support for an Angular Universal site like the site under /demo (aka the site from Jason's original proof of concept). Right now, it's missing some of the crucial monorepo logic that Matt built into the Next plugin. I think this can be excluded from a beta.

Callouts:

To-Do in a separate PR:

lindsaylevine commented 3 years ago

according to tara:

Screen Shot 2021-07-26 at 9 29 26 AM

we can always add later if needed

tzmanics commented 3 years ago

This is really great! Nice work!

I notice that in the readme we say to create a netlify.toml that has different information from demo/netlify.toml. Should they be the same?

lindsaylevine commented 3 years ago

This is really great! Nice work!

I notice that in the readme we say to create a netlify.toml that has different information from demo/netlify.toml. Should they be the same?

@tzmanics what different information are you referring to? the build command is the same, just in an npm script. the extra configs ([[redirects]] and [functions]) will be removed when the CLI pieces get fixed by workflow. is there somethin else?