search

netlify / angular-runtime

The Angular Runtime allows Angular to run on Netlify with zero configuration
https://docs.netlify.com/integrations/frameworks/angular/
MIT License
19 stars 11 forks source link

feat!: add support for Angular v17 #67

Closed Skn0tt closed 11 months ago

Skn0tt commented 11 months ago

This PR contains a big overhaul of our Angular Plugin, adding support for Angular v17. (I was sneaky and found the release candidates!)

As part of this, we're massively simplifying the plugin. We generate an edge function that thinly wraps around the output generated by ng build, there's no mangling with angular.json required anymore.

We're also renaming the package to @netlify/angular-runtime, to be more in-line with our other framework plugin names.

netlify[bot] commented 11 months ago

Deploy Preview for plugin-angular-universal-demo ready!

Name Link
Latest commit 0a43c8f9ad33178b1e096d8574c686c0b2816a47
Latest deploy log https://app.netlify.com/sites/plugin-angular-universal-demo/deploys/654b63d1931b840008a917ce
Deploy Preview https://deploy-preview-67--plugin-angular-universal-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Skn0tt commented 11 months ago

Finally fixed the Deploy! https://deploy-preview-67--plugin-angular-universal-demo.netlify.app/dashboard

Skn0tt commented 11 months ago

I believe i've implemented everything necessary! Noice. Looking forward to release this :D

Skn0tt commented 11 months ago

https://github.com/netlify/angular-runtime/pull/67/commits/31b44b9877ac37211aa037e5a72eaed4afae3a93 ensures that this also works out-of-the-box for ng create without --ssr.

Skn0tt commented 11 months ago

Added a way of working with netlify.request and netlify.context locally.

Skn0tt commented 11 months ago

@ascorbic could I bother you with one more review on the changes since you last looked? I've added a couple things, and am happy with the state of things now.

Skn0tt commented 11 months ago

Gonna move forward and merge this now, so I can fix any bugs that release-please might have. Feel free to still review, so we can address in a follow-up.