search

netlify / angular-runtime

The Angular Runtime allows Angular to run on Netlify with zero configuration
https://docs.netlify.com/integrations/frameworks/angular/
MIT License
18 stars 7 forks source link

fix: `excludedPath` contained relative paths for some prerendered static files #74

Closed Skn0tt closed 8 months ago

Skn0tt commented 8 months ago

The logic for detecting all files in a directory was off, and generated wrong paths. This resulted in wrong paths being excluded. This PR fixes that, and adds a very simple unit test setup to prove it.

netlify[bot] commented 8 months ago

Deploy Preview for plugin-angular-universal-demo ready!

Name Link
Latest commit 9b4accf9a0d3b39877347014e35f870038fdba20
Latest deploy log https://app.netlify.com/sites/plugin-angular-universal-demo/deploys/654cf69293b0f3000809a858
Deploy Preview https://deploy-preview-74--plugin-angular-universal-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Skn0tt commented 8 months ago

looks like the CI needs some tending

Skn0tt commented 8 months ago

https://github.com/netlify/angular-runtime/pull/74/commits/7b8c1fb4d156df3fcd18e30a8b31ee9206198f0f contains an update to the minimum supported version of Node.js. This could technically be seen as a breaking change, but given that Angular compilation would fail anyways on Node versions below that, I believe it's fine to put this in a patch update.