search

netlify / angular-runtime

The Angular Runtime allows Angular to run on Netlify with zero configuration
https://docs.netlify.com/integrations/frameworks/angular/
MIT License
18 stars 7 forks source link

fix: handle missing angular dependencis error #91

Closed JGAntunes closed 7 months ago

JGAntunes commented 7 months ago

Follow up to #87, our observability picked up on another unhandled internal error:

This time is the unhandled resolve exception. This should take care of that hopefully 👍

netlify[bot] commented 7 months ago

Deploy Preview for plugin-angular-universal-demo ready!

Name Link
Latest commit 72226d97ab062639230f17c9892947a521e1dda5
Latest deploy log https://app.netlify.com/sites/plugin-angular-universal-demo/deploys/6564d637cc1b0900084e748b
Deploy Preview https://deploy-preview-91--plugin-angular-universal-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Skn0tt commented 7 months ago

it looks like the test runs are installing the plugin from NPM, as opposed to using the local one 🤔 https://github.com/netlify/angular-runtime/actions/runs/7004802463/job/19053297061?pr=91#step:6:285

JGAntunes commented 7 months ago

@ascorbic @Skn0tt done. Mind re-👀-ing?