netlify / build-image

This is the build image used for running automated builds
MIT License
497 stars 196 forks source link

Add Haldo linting to build image dockerfile #815

Closed lukasholzer closed 2 years ago

lukasholzer commented 2 years ago

To ensure the quality of our Dockerfile a static code analysis is a must.

For this there is Haldolint (a docker linting tool that uses shellcheck under the hood to check if everything is right)

Currently running docker run --rm -i hadolint/hadolint < Dockerfile inside the build image results in a lot of errors that we should tackle!

It follows the docker best practises: https://docs.docker.com/develop/develop-images/dockerfile_best-practices/

CleanShot 2022-07-12 at 11 00 27

lukasholzer commented 2 years ago

Already done in #818